[PATCH] D80406: [LLD][ThinLTO] A switch to allow compilation of only one module.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/thinlto-single-module.ll:8
+
+; --thinlto-single-module=main.o should result in only main.o compiled, of which
+; the object code is saved in single1.o1. Note that single1.o is always the dummy
----------------
Use `;; ` for comments.

There are efforts making FileCheck detect potentially disabled check directives. It may have some false positives. `;; ` is a good way (and already used a lot (`## `) in other lld tests) to suppress them.


================
Comment at: llvm/lib/LTO/LTO.cpp:857
+    // specified switch values are going to be compiled.
+    for (auto &Name : Conf.ThinLTOModulesToCompile) {
+      if (BM.getModuleIdentifier().contains(Name)) {
----------------
const std::string &


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80406/new/

https://reviews.llvm.org/D80406