[PATCH] D80602: [BranchFolding] Drop location when hoisting

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 16:23:18 PDT 2020


vsk added inline comments.


================
Comment at: llvm/lib/CodeGen/BranchFolding.cpp:2028
+  for (auto &TBBI : *TBB)
+    TBBI.setDebugLoc(DebugLoc());
+
----------------
To summarize some offline discussions:
- We haven't yet nailed down what should happen to hoisted debug insts, we should discuss (maybe in a follow-up to D80052)
- D80670 flags the issue here; if we're going to hoist DBG_VALUEs here, they need a location


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80602/new/

https://reviews.llvm.org/D80602





More information about the llvm-commits mailing list