[PATCH] D80167: [mlir][gpu] Refactor ConvertGpuLaunchFuncToCudaCalls pass.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 14:10:17 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/include/mlir/Conversion/GPUCommon/GPUCommonPass.h:12
+#include "mlir/Support/LLVM.h"
+#include <functional>
+#include <memory>
----------------
Where is functional used?


================
Comment at: mlir/include/mlir/Conversion/GPUCommon/GPUCommonPass.h:14
+#include <memory>
+#include <string>
+#include <vector>
----------------
Why are these necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80167/new/

https://reviews.llvm.org/D80167





More information about the llvm-commits mailing list