[PATCH] D79688: [mlir] loop::ForOp: provide builders with callbacks for loop body

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp:88
   });
+  ivs[0].getParentBlock()->dump();
 
----------------
Was this ever removed?


================
Comment at: mlir/lib/Dialect/SCF/SCF.cpp:286
+    // Set the builder to point to the body of the newly created loop. We don't
+    // do this in the callback beacause the builder is reset when the callback
+    // returns.
----------------
nit: typo beacause


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79688/new/

https://reviews.llvm.org/D79688