[PATCH] D79954: [mlir] [VectorOps] Implement vector.create_mask lowering to LLVM IR

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/Vector/VectorTransforms.cpp:1239
 
+class CreateMaskOpLowering : public OpRewritePattern<vector::CreateMaskOp> {
+public:
----------------
Can you add comments to what the expected output is given a mask input? Lowerings should really be documented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79954/new/

https://reviews.llvm.org/D79954