[PATCH] D79940: [mlir] Rename conversions involving ex-Loop dialect to mention SCF

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 13:03:12 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/include/mlir/Conversion/SCFToGPU/SCFToGPUPass.h:8
 //===----------------------------------------------------------------------===//
 #ifndef MLIR_CONVERSION_LOOPSTOGPU_LOOPSTOGPUPASS_H_
 #define MLIR_CONVERSION_LOOPSTOGPU_LOOPSTOGPUPASS_H_
----------------
Looks like this was missed.


================
Comment at: mlir/lib/Conversion/SCFToGPU/SCFToGPUPass.cpp:22
+#define PASS_NAME "convert-scf-to-gpu"
 #define LOOPOP_TO_GPU_PASS_NAME "convert-loop-op-to-gpu"
 
----------------
Should this be renamed/removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79940/new/

https://reviews.llvm.org/D79940





More information about the llvm-commits mailing list