[PATCH] D78346: Fix Windows command line bug when last token in response file is ""

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 09:11:38 PDT 2020


amccarth accepted this revision.
amccarth added a subscriber: rnk.
amccarth added a comment.
This revision is now accepted and ready to land.

Ah, I guess the diff was based off the old head rather than the rebased one.  Phabricator highlighted all that code as part of this patch.

Sorry about that.  I'll have to redirect most of those comments @rnk .  That'll be awkward.

Now that Phabricator is showing just seeing fix and test improvements, it looks great.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78346/new/

https://reviews.llvm.org/D78346





More information about the llvm-commits mailing list