[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

[Balázs Kéri via Phabricator via llvm-commits]

balazske added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:917
     assert(isa<GlobalsSpaceRegion>(sReg) || isa<StackSpaceRegion>(sReg) ||
            isa<BlockDataRegion>(sReg) || isa<UnknownSpaceRegion>(sReg));
   }
----------------
This assert should not be duplicated. It has the place in `VarRegion` or `NonParamVarRegion`, but not both.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:976
+
+/// ParamVarRegion - Represents a region for paremters. Only parameters of the
+/// function in the current stack frame are represented as `ParamVarRegion`s.
----------------
typo here: "paremters"


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:978
+/// function in the current stack frame are represented as `ParamVarRegion`s.
+/// Parameters of top-level analyzed functions as well as captured paremeters
+/// by lambdas and blocks are repesented as `VarRegion`s.
----------------
"paremeters"


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:979
+/// Parameters of top-level analyzed functions as well as captured paremeters
+/// by lambdas and blocks are repesented as `VarRegion`s.
+
----------------
`NonParamVarRegion`s ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80522/new/

https://reviews.llvm.org/D80522