[PATCH] D80535: [ObjectYAML][MachO] Add error handling in MachOEmitter.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Some comment nits, otherwise LGTM. Please wait for @alexshap to confirm too.



================
Comment at: llvm/test/ObjectYAML/MachO/fat_macho_i386_x86_64.yaml:1
-# RUN: yaml2obj %s | obj2yaml | FileCheck %s
+## This file contains test cases for generating the Fat MachO binaries.
+
----------------
generating the -> generating

I think canonically it should be "Mach-O" rather than "MachO" here and elsewhere in comments.


================
Comment at: llvm/test/ObjectYAML/MachO/fat_macho_i386_x86_64.yaml:93
+FatArchs:
+  # 2 FatArchs are expected.
+  - cputype:    0x00000007
----------------
'##' for comments.


================
Comment at: llvm/test/ObjectYAML/MachO/sections.yaml:1
-# RUN: yaml2obj %s | obj2yaml | FileCheck %s
+## This file contains test cases for generating sections in the MachO object file.
+
----------------
"in the MachO object file" -> "in Mach-O object files" I think reads better.


================
Comment at: llvm/test/ObjectYAML/MachO/sections.yaml:335
+        size:      2
+        offset:    0x00000001 # Specify the offset that makes __sec1 and __sec2 overlap.
+        align:     1
----------------
"##"
the -> an


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80535/new/

https://reviews.llvm.org/D80535