[PATCH] D80546: [llvm-readelf] - Split GNUStyle<ELFT>::printHashHistogram. NFC.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with suggested comment fixes.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4667
 
+// Hash histogram shows  statistics of how efficient the hash was for the
+// dynamic symbol table. The table shows number of hash buckets for different
----------------
Whilst you're moving the comment, let's fix it:

Nit: double space between "shows" and "statistics".


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4668
+// Hash histogram shows  statistics of how efficient the hash was for the
+// dynamic symbol table. The table shows number of hash buckets for different
+// lengths of chains as absolute number and percentage of the total buckets.
----------------
shows the number


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4669
+// dynamic symbol table. The table shows number of hash buckets for different
+// lengths of chains as absolute number and percentage of the total buckets.
+// Additionally cumulative coverage of symbols for each set of buckets.
----------------
as an absolute number


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4670
+// lengths of chains as absolute number and percentage of the total buckets.
+// Additionally cumulative coverage of symbols for each set of buckets.
+template <class ELFT>
----------------
buckets. Additionally cumulative -> buckets, and the cumulative


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80546/new/

https://reviews.llvm.org/D80546