[PATCH] D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol

Wed May 27 01:02:44 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/aix-user-defined-memcpy.ll:11-12

+; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff -mcpu=pwr4 \
+; RUN: -mattr=-altivec < %s | FileCheck %s
+
----------------
I know this is what was done elsewhere in the test, but I don't think we should blindly copy bad practice here, and instead you should just reflow the line like I suggested in the other test. If you do think the `llc` line is too long and needs to broken up, I'd recommend the following:

```
; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff \
; RUN:     -mcpu=pwr4 -mattr=-altivec < %s | \
; RUN:   FileCheck %s
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78929/new/

https://reviews.llvm.org/D78929