[PATCH] D80099: [llvm-objcopy][MachO] Add support for removing Swift symbols

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 27 01:02:41 PDT 2020


jhenderson added a comment.

I'm okay with using the short option (although a long option wouldn't hurt too FWIW). I think it's useful to have compatibility with as many strip tools as we reasonably can. Whilst GNU compatibility is obviously our primary concern, where GNU doesn't have certain options but other versions of strip do, I think we should emulate them. The benefits have already been outlined (less friction in transitioning etc). A good example is the --strip-sections option which I believe came from eu-strip. I would hope that GNU might consider what options other tools already provide when choosing new options, so I would hope that risk of future compatibility is reduced. When there is no precedent for a short option in other strip/objcopy tools however, I think it is highly desirable to not add a short option alias ourselves, unless the meaning is obvious (e.g. in GNU dumping tools, -C always means --demangle, so if we have --demangle, having -C is fine even though GNU don't currently).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80099/new/

https://reviews.llvm.org/D80099





More information about the llvm-commits mailing list