[PATCH] D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable

[Steve Scalpone via Phabricator via llvm-commits]

sscalpone added a comment.

+1 for good messages.

I think there's universal agreement that code that cannot be reached with user input should be marked as unreachable.  The point of contention is whether or not code in a RELEASE build is allowed to catch & report that situation.

What about something like:

  #define DIE(x) { Fortran::common::die(x " at " __FILE__ "(%d)", __LINE__); LLVM_BUILTIN_UNREACHABLE; }

?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79507/new/

https://reviews.llvm.org/D79507