[PATCH] D80608: [llvm-mc] Make the suffix matcher more accurate.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 21:14:20 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:461
+    return Kind == Register &&
+           (X86MCRegisterClasses[X86::VR128XRegClassID].contains(getReg()) ||
+            X86MCRegisterClasses[X86::VR256XRegClassID].contains(getReg()) ||
----------------
Include MMX?

This is also currently broken

maskmov %mm0, %mm0

should only accept
maskmovq %mm0, %mm0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80608/new/

https://reviews.llvm.org/D80608





More information about the llvm-commits mailing list