[PATCH] D80535: [ObjectYAML][MachO] Add error handling in MachOEmitter.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 19:38:08 PDT 2020


Higuoxing updated this revision to Diff 266394.
Higuoxing added a comment.

Addressed comments.

- Use `errc::invalid_argument` instead of `inconvertibleErrorCode()`
- Remove assertions
- Move test cases to their own test files.
- Modify the Fat MachO test case according to the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80535/new/

https://reviews.llvm.org/D80535

Files:
  llvm/lib/ObjectYAML/MachOEmitter.cpp
  llvm/test/ObjectYAML/MachO/fat_macho_i386_x86_64.yaml
  llvm/test/ObjectYAML/MachO/sections.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80535.266394.patch
Type: text/x-patch
Size: 8582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200527/e5fb5907/attachment.bin>


More information about the llvm-commits mailing list