[PATCH] D80579: [llvm] Add function feature extraction analysis

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 19:05:40 PDT 2020


mtrofin added a comment.

In D80579#2056301 <https://reviews.llvm.org/D80579#2056301>, @jdoerfert wrote:

> Last high-level comment: Should we call this "FeatureAnalysis" (without the Inline)? I can see us reusing this for other (ML) purposes. Nothing in this code is really tied or specific to the inliner I guess.
>
> That said, I think the "analysis" is reasonable given the FIXME (thx!). It is clear there is improvement potential and the results are properly named and described.


I'd prefer waiting to see another usecase before renaming, or potentially refactoring (depends on what we'll learn when we get to that usecase) - wdyt?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80579/new/

https://reviews.llvm.org/D80579





More information about the llvm-commits mailing list