[PATCH] D80586: Refactor Suffix Tree from MachineOutliner to LibSupport

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 18:33:39 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/include/llvm/Support/SuffixTree.h:17
+
+using namespace llvm;
+
----------------
efriedma wrote:
> LLVM headers shouldn't `using namespace llvm;`
Also, I guess I didn't mention it, but classes in LLVM headers should be defined in the "llvm" namespace.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80586/new/

https://reviews.llvm.org/D80586





More information about the llvm-commits mailing list