[PATCH] D80422: Enable `align <n>` to be used in intrinsic definitions.

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenIntrinsics.h:157
 
-  std::vector<std::pair<unsigned, ArgAttribute>> ArgumentAttributes;
+  std::vector<std::tuple<unsigned, ArgAttribute, uint64_t>> ArgumentAttributes;
 
----------------
jdoerfert wrote:
> Every time I see a use of tuple I ask myself the same question: Wouldn't a POD-like struct with some properly named members be better? I feel `std::get<1>(T)` is somewhat less helpful than `T->Index`. I don't need you to change it here but it's something to think about. In particular it might help to remove magic numbers below, e.g., 0 for the value.
+1 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80422/new/

https://reviews.llvm.org/D80422