[PATCH] D79100: [LV][TTI] Emit new IR intrinsic llvm.get.active.mask for tail-folded loops

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D79100#2055802 <https://reviews.llvm.org/D79100#2055802>, @SjoerdMeijer wrote:

> Many thanks for taking a look Florian!
>
> > I think introducing a VPInstruction opcode for the new intrinsic makes sense and fits in the current scheme. But I think there's no need to bundle the langref, TTI and LV changes into a single patch. IMO would be good to split at least the LV part off, to focus on discussing the implementation details in LV there
>
> Ok, but Just double checking that I get this right:
>
> - In the LV part, we do use and check TTI.emitGetActiveLaneMask, so I guess that means we have LV + TTI in one patch,


I'd just put the LV parts in a separate patch and the TTI stuff in a different patch (the former depending on the latter). The way I see it, those are changes to 2 separate areas  of the code, with potentially different people to approve. Also, if there's problem with the LV patch, It can be reverted in isolation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79100/new/

https://reviews.llvm.org/D79100