[PATCH] D80497: Make mlir::Value's bool conversion operator explicit

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 14:11:21 PDT 2020


dblaikie added a comment.

@mehdi_amini - would you mind writing some kind of comment when you approve a patch in Phabricator? Without any text in the approval, the email is not sent to the mailing list (only to the people in the review) & it looks like the patch is then committed without approval (according to the mail on the mailing list).
@rriddle - would you mind not setting your Herald rule to "requires review" unless you plan to review everything that triggers that rule - otherwise, again, it ends up looking like a patch was committed without the intended scrutiny.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80497/new/

https://reviews.llvm.org/D80497





More information about the llvm-commits mailing list