[PATCH] D70085: [AMDGPU] NFC target dependent requiresUniformRegister refactored out

[Matt Arsenault via Phabricator via llvm-commits]

arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: kerbowa.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:31
 #include "llvm/ADT/StringRef.h"
+#include "llvm/Analysis/LegacyDivergenceAnalysis.h"
 #include "llvm/Analysis/ProfileSummaryInfo.h"
----------------
No reason to spread this to generic code


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:10975-10976
+                                   MachineFunction &MF, const Value *V) const {
+  return !requiresUniformRegister(MF, V) &&
+         TargetLoweringBase::isDivergent(DA, MF, V);
+}
----------------
requiresUniformRegister is an expensive check (which really should be eliminated entirely), so should be made second only when really necessary


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70085/new/

https://reviews.llvm.org/D70085