[PATCH] D80218: Use configure depends to trigger reconfiguration when LLVMBuild files change

[David Chisnall via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGe72cba975735: Use configure depends to trigger reconfiguration when LLVMBuild files change (authored by danielframpton, committed by theraven).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80218/new/

https://reviews.llvm.org/D80218

Files:
  llvm/utils/llvm-build/llvmbuild/main.py


Index: llvm/utils/llvm-build/llvmbuild/main.py
===================================================================
--- llvm/utils/llvm-build/llvmbuild/main.py
+++ llvm/utils/llvm-build/llvmbuild/main.py
@@ -563,19 +563,10 @@
         f.write("""
 # LLVMBuild CMake fragment dependencies.
 #
-# CMake has no builtin way to declare that the configuration depends on
-# a particular file. However, a side effect of configure_file is to add
-# said input file to CMake's internal dependency list. So, we use that
-# and a dummy output file to communicate the dependency information to
-# CMake.
-#
-# FIXME: File a CMake RFE to get a properly supported version of this
-# feature.
 """)
         for dep in dependencies:
             f.write("""\
-configure_file(\"%s\"
-               ${CMAKE_CURRENT_BINARY_DIR}/DummyConfigureOutput)\n""" % (
+set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS \"%s\")\n""" % (
                 cmake_quote_path(dep),))
 
         # Write the properties we use to encode the required library dependency


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80218.266234.patch
Type: text/x-patch
Size: 1047 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200526/5694b8ff/attachment.bin>