[PATCH] D80564: AMDGPU: Fix wrong null value for private address space

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 08:38:59 PDT 2020


arsenm created this revision.
arsenm added reviewers: rampitec, yaxunl.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

I'm guessing this was a holdover from when 0 was an invalid stack
pointer, but surprised nobody has discovered this before.

      

Also don't allow offset folding for -1 pointers, since it looks weird
to partially fold this.


https://reviews.llvm.org/D80564

Files:
  llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-load-private.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-addrspacecast.mir
  llvm/test/CodeGen/AMDGPU/addrspacecast.ll
  llvm/test/CodeGen/AMDGPU/nullptr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80564.266225.patch
Type: text/x-patch
Size: 15331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200526/df8801df/attachment-0001.bin>


More information about the llvm-commits mailing list