[PATCH] D80402: [NFC][XCOFF][AIX] Return function entry point symbol with dedicate function

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetLoweringObjectFile.h:249
+  /// Otherwise, returns nulltpr.
+  virtual MCSymbol *getFunctionEntryPointSymbol(const Function *F,
+                                                const TargetMachine &TM) const {
----------------
DiggerLin wrote:
> the code should be never come to here.  maybe report an fatal error maybe better.
Current code won't come here. But I think returning a nullptr have more benefit than just report_fatal_error. Sometimes, we could write code that relying on it being return nulltpr on Targets that does not support it (instead of relying on target query). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80402/new/

https://reviews.llvm.org/D80402