[PATCH] D79936: [FileCheck] Add function call support to numerical expressions.

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

Please note that the patch to add support for signed values (https://reviews.llvm.org/D60390) is at an advanced stage of review.



================
Comment at: llvm/docs/CommandGuide/FileCheck.rst:693
+  * a function call, or
+  * an expression followed by an operator and an expression.
 
----------------
Why change this sentence? Recursion only happens on one of the operand only.


================
Comment at: llvm/docs/CommandGuide/FileCheck.rst:708-709
+
+  ``!(<expr>)`` is a precedence operator, which can be used to force the order
+  of operations when symbolic operators are in use.
+
----------------
I don't think the exclamation mark should be required here. A parenthesis pair should be enough to force precedence. Note that there was a patch to adds support for that and you might want to rebase your patch on top of it.


================
Comment at: llvm/lib/Support/FileCheck.cpp:427-430
+      if (Expr.startswith(","))
+        break;
+      if (Expr.startswith(")"))
+        break;
----------------
Please group the two tests together, together they test whether it's an exit condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79936/new/

https://reviews.llvm.org/D79936