[PATCH] D79977: [ELF][PPC64] Synthesize _savegpr[01]_{14..31} and _restgpr[01]_{14..31}

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 07:00:53 PDT 2020


sfertile accepted this revision.
sfertile added a comment.
This revision is now accepted and ready to land.

One comment but otherwise LGTM.



================
Comment at: lld/ELF/Arch/PPC64.cpp:125
+static void writeSequence(MutableArrayRef<uint32_t> buf, const char *prefix,
+                          int from, uint32_t firstInsn,
+                          ArrayRef<uint32_t> tail) {
----------------
nit: `from` is always 14 so we don't need it as an argument, we can just always start the loop at 14.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79977/new/

https://reviews.llvm.org/D79977





More information about the llvm-commits mailing list