[PATCH] D80466: [X86] Improve i8 + 'slow' i16 funnel shift codegen

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 03:11:47 PDT 2020


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/fshl.ll:22-23
+; X86-NEXT:    movl {{[0-9]+}}(%esp), %eax
+; X86-NEXT:    shll $8, %eax
+; X86-NEXT:    orl %edx, %eax
+; X86-NEXT:    andb $7, %cl
----------------
foad wrote:
> Would it be worth trying to generate just `movb %al, %dh` instead of zext+shll+orl?
Yes that might be useful but probably should be done generally. I don't know much about the hi-byte move logic @craig.topper might be able to advise?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80466/new/

https://reviews.llvm.org/D80466





More information about the llvm-commits mailing list