[PATCH] D80520: [yaml2obj] - Map section names to chunks for each ELFYAML::ProgramHeader early. NFCI.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one suggestion.



================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:503-506
+  std::vector<SectionName> Sections;
+
+  // This vector is parallel to Sections and contains corresponding chunks.
+  std::vector<Chunk *> Chunks;
----------------
Up to you, but maybe:
```
  Optional<llvm::yaml::Hex64> Offset;

  std::vector<SectionName> Sections;
  // This vector is parallel to Sections and contains corresponding chunks.
  std::vector<Chunk *> Chunks;
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80520/new/

https://reviews.llvm.org/D80520