[PATCH] D80258: Fix SourceMgrDiagnosticHandler::convertLocToSMLoc for unknown line/column scenerio.

Jing Pu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 25 22:28:48 PDT 2020


Jing added a comment.

I found there are some internal tests (on diagnostics) that rely on column zero being the first column.
I am not so sure whether we should adopt that behavior and change API (i.e. treating only row zero being an unknown location) or fix the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80258/new/

https://reviews.llvm.org/D80258





More information about the llvm-commits mailing list