[PATCH] D80203: [ObjectYAML][DWARF] Add DWARF entry in ELFYAML.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 266098.
Higuoxing added a comment.

Address comments.

- Make `emitDWARF()` be a static helper function.
- Simplify the logic inside `shouldEmitDWARF()`
- Use `llvm-readelf -S` rather than `llvm-readelf --section-headers`
- Make error messages be consistent with others.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80203/new/

https://reviews.llvm.org/D80203

Files:
  llvm/include/llvm/ObjectYAML/DWARFYAML.h
  llvm/include/llvm/ObjectYAML/ELFYAML.h
  llvm/lib/ObjectYAML/DWARFYAML.cpp
  llvm/lib/ObjectYAML/ELFEmitter.cpp
  llvm/lib/ObjectYAML/ELFYAML.cpp
  llvm/test/tools/yaml2obj/ELF/DWARF/debug-str.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80203.266098.patch
Type: text/x-patch
Size: 13868 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200526/17cbdec5/attachment.bin>