[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

[Victor Huang via Phabricator via llvm-commits]

NeHuang marked an inline comment as done.
NeHuang added inline comments.


================
Comment at: clang/lib/Basic/Targets/PPC.cpp:339
 
   if (!(ArchDefs & ArchDefinePwr9) && (ArchDefs & ArchDefinePpcgr) &&
       llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) {
----------------
lei wrote:
> NeHuang wrote:
> > I think we also need to check for `ArchDefinePwr10` and `ArchDefineFuture` based on the comment  "// We have __float128 on PPC but not power 9 and above."
> > 
> > `!(ArchDefs & ArchDefinePwr9)` -> `!(ArchDefs & (ArchDefinePwr9 | ArchDefinePwr10 | ArchDefineFuture))`
> I would think this would be redundant since `-mcpu=pwr10` also defines `ArchDefinePwr9` ...
Yeah. That makes sense. Thanks for the explanation!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80020/new/

https://reviews.llvm.org/D80020