[PATCH] D79003: [DAG] Add SimplifyDemandedVectorElts binop SimplifyMultipleUseDemandedBits handling

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 25 02:38:42 PDT 2020


RKSimon added a comment.

In D79003#2052679 <https://reviews.llvm.org/D79003#2052679>, @spatel wrote:

> LGTM.
>  I'd sink the isAllOnesValue() check and/or hoist the CombineTo() into the lambda too for still less repeated code, but maybe there's more differentiation from known undef that could happen here?


I'll move the CombineTo handling into the lambda as well - the isAllOnes() I'm going to leave out until I can work out how to best merge it with KnownUndef as mentioned in the TODOs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79003/new/

https://reviews.llvm.org/D79003





More information about the llvm-commits mailing list