[PATCH] D79664: [ELF] Support --pack-dyn-relocs=rel+relr

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 24 13:52:03 PDT 2020


MaskRay added a subscriber: danalbert.
MaskRay added a comment.

In D79664#2032775 <https://reviews.llvm.org/D79664#2032775>, @mcgrathr wrote:

> If people are agreed, I think separate `-z rel`, `-z relr`, and `-z android-relocs` flags that operate independent makes the most sense.  The existing `--pack-dyn-relocs` can be accepted for compatibility, but need not get any new supported values.


`-z rel` and `-z relr` look good to me. I created D80496 <https://reviews.llvm.org/D80496> for -z rel and -z rela. (It should work out of the box with --pack-dyn-relocs=android)

I don't know how the magic `APS2` was picked but I think the -z option for Android packed relocation section can mention the magic, i.e. `-z pack-dyn-relocs=APS2` or similar. @danalbert

On the GNU ld side, I created https://sourceware.org/pipermail/binutils/2020-May/111086.html but there has been no response ¯\_(ツ)_/¯


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79664/new/

https://reviews.llvm.org/D79664





More information about the llvm-commits mailing list