[PATCH] D80478: [X86][AVX] Call SimplifyDemandedBits on MaskedLoadSDNode with non-boolean masks

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 24 00:29:37 PDT 2020


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:42933
   // TODO: Expanding load with constant mask may be optimized as well.
-  if (Mld->isExpandingLoad())
-    return SDValue();
-
-  if (Mld->getExtensionType() == ISD::NON_EXTLOAD) {
+  if (!Mld->isExpandingLoad() && Mld->getExtensionType() == ISD::NON_EXTLOAD) {
     if (SDValue ScalarLoad = reduceMaskedLoadToScalarLoad(Mld, DAG, DCI))
----------------
craig.topper wrote:
> Do we ever have expanding loads with non-i1 masks?
Not that I know of - I'll put the early-out back


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80478/new/

https://reviews.llvm.org/D80478





More information about the llvm-commits mailing list