[PATCH] D79066: [Support] Class to facilitate file locking

Fri May 22 13:26:43 PDT 2020

dblaikie accepted this revision.
dblaikie added a comment.

In D79066#2050636 <https://reviews.llvm.org/D79066#2050636>, @sepavloff wrote:

> In D79066#2050586 <https://reviews.llvm.org/D79066#2050586>, @labath wrote:
>
> > In D79066#2050312 <https://reviews.llvm.org/D79066#2050312>, @dblaikie wrote:
> >
> > > The two changes to Error.h (message/cantFail) look like they're unrelated to this patch & should be removed/not committed?
> >
> >
> > I think they're needed because this introduces a circular dependency between `raw_ostream` and `Error` classes. Does not seem unreasonable to me, but if we don't want that, then we need to revisit this idea...
>
>
> Exactly. I got compilation errors because of `Expected` used in declaration of `raw_ostream::tryToLock`. But now I tried removing these changes and compilation was successful. Probably the recent Visual Studio update solved this problem. So I removed these changes. If however someone using old MS compiler will see compilation fails, we know what to do.

Nah, that's a fine reason - thanks for explaining!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79066/new/

https://reviews.llvm.org/D79066