[PATCH] D80453: [flang] Fixes for problems with declaring procedure entities

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 22 12:52:42 PDT 2020


PeteSteinfeld created this revision.
PeteSteinfeld added reviewers: tskeith, klausler.
Herald added a reviewer: DavidTruby.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We were not detecting declaring multiple interfaces to the same procedure.
Also, we were not handling the initialization of entitiies where the associated
Symbol had previously had errors.

I added a boolean to ProcEntityDetails to indicate if set_interface() had been
called.  I then checked that boolean when calling set_interface() and emitting
an error message if the interface was already set.

Also, in situations where we were emitting error messages for symbols, I set
the Error flag on the Symbol.  Then when performing initialization on the
Symbol, I first check to see if the Symbol had an error.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80453

Files:
  flang/include/flang/Semantics/symbol.h
  flang/lib/Semantics/resolve-names.cpp
  flang/test/Semantics/resolve91.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80453.265784.patch
Type: text/x-patch
Size: 8354 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200522/42650925/attachment.bin>


More information about the llvm-commits mailing list