[PATCH] D80433: [clang-tblgen][CommandLine][ManagedStatic] Fix build errors with clang-tblgen in Debug mode using MSVC 2019 v16.6

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 22 12:20:37 PDT 2020


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/Support/ManagedStatic.h:46
+// Check MSVC version here
+// (https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?redirectedfrom=MSDN&view=vs-2019).
+#if !defined(_MSC_VER) || (_MSC_VER >= 1925) || defined(__clang__)
----------------
I'm not sure what the style rules are about exceeding the column-80 limit for URLs. Maybe just refer people to http://llvm.org/PR41367 ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80433/new/

https://reviews.llvm.org/D80433





More information about the llvm-commits mailing list