[PATCH] D80316: [HardwareLoops] Intrinsic LangRef descriptions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 22 11:15:32 PDT 2020


efriedma added a comment.

The descriptions here related to llvm.loop.decrement still aren't really sufficient.  The description of llvm.set.loop.iterations says "It's a hint to the backend".  But llvm.loop.decrement is apparently depending on llvm.set.loop.iterations to have some sort of side-effect.

Really, I suspect the problem here is that llvm.loop.decrement is actually just unsound, and we avoid any issues with it simply by running it really late in the pass pipeline.  But if that's the case, I'd prefer to state that explicitly.



================
Comment at: llvm/docs/LangRef.rst:14960
+      declare i1 @llvm.loop.decrement.reg.i32(i32)
+      declare i1 @llvm.loop.decrement.reg.i64(i64)
+
----------------
"llvm.loop.decrement.i64", not "llvm.loop.decrement.reg.i64"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80316/new/

https://reviews.llvm.org/D80316





More information about the llvm-commits mailing list