[PATCH] D77589: libclc: Add Mesa/SPIR-V/DXIL target

Fri May 22 10:43:22 PDT 2020

daniels marked an inline comment as done.
daniels added inline comments.

================
Comment at: libclc/spirv-mesa3d-dxil/lib/subnormal_config.cl:1
 /*
- * Copyright (c) 2014,2015 Advanced Micro Devices, Inc.
----------------
tstellar wrote:
> daniels wrote:
> > tstellar wrote:
> > > What's going on with this file?  Is subnormal_config.cl a new file?
> > It was copied and then just had its functionality decimated. I don't know what's going on with the copyright year, though. Should I just resubmit with the header reconciled?
> So git tracked the copy?  I think it would be less confusing if you updated the patch, so that this is just a new file.
Yeah, git just does that under the scenes. It's not an explicit request, but it helpfully finds that for you. Even if you somehow break through that, Phabricator will also automatically reconstruct it for you too. I don't think there's a practical way to subvert this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77589/new/

https://reviews.llvm.org/D77589