[PATCH] D80311: [lld][test] Expand testing for dynamic-list and export-dynamic

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/dynamic-list-patterns.s:7
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+
----------------
`-unknown-linux` can be dropped (this tests generic ELF behavior)


================
Comment at: lld/test/ELF/dynamic-list-patterns.s:9
+
+# RUN: echo "{ [fb]o?1*; _Z1fv; extern \"C++\" { \"g()\"; }; };" > %t.list
+# RUN: ld.lld -pie --dynamic-list %t.list %t.o -o %t.elf
----------------
Use ' for outermost quotes


================
Comment at: lld/test/ELF/dynamic-list-patterns.s:11
+# RUN: ld.lld -pie --dynamic-list %t.list %t.o -o %t.elf
+# RUN: llvm-readelf --dyn-symbols %t.elf | FileCheck %s
+
----------------
`--dyn-syms`

You can also use `llvm-nm -D`


================
Comment at: lld/test/ELF/export-symbol-types.s:31
+
+# RUN: llvm-readelf --dyn-symbols %t.elf | FileCheck %s
+# RUN: llvm-readelf --dyn-symbols %tlist.elf | FileCheck %s
----------------
`--dyn-syms`


================
Comment at: lld/test/ELF/export-symbol-types.s:32
+# RUN: llvm-readelf --dyn-symbols %t.elf | FileCheck %s
+# RUN: llvm-readelf --dyn-symbols %tlist.elf | FileCheck %s
+
----------------
Can you find existing tests which can be deleted after you add the more comprehensive test here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80311/new/

https://reviews.llvm.org/D80311