[PATCH] D80019: [WebAssembly] Fixed debugloc in DebugFixup pass
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 21 17:21:27 PDT 2020
aheejin added a comment.
In D80019#2050293 <https://reviews.llvm.org/D80019#2050293>, @aardappel wrote:
> Yes, likely.
> Either way, I generally don't think such a small change needs a follow-up commit.
- As I said before, if you think something is unnecessary, I'd appreciate if you just say so, rather than ignoring the comment itself. (I feel I saw this several times even before I suggested this to you first in the previous CL.) I think this issue is minor too, but I pinged you because of that.
- Many people fix minor things or follow-ups with just commits without uploading a CL in Phabricator when they don't really need reviews. Not suggesting to fix exactly this, but just FYI for the next time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80019/new/
https://reviews.llvm.org/D80019
More information about the llvm-commits
mailing list