[PATCH] D80049: [lld-macho] Add some relocation validation logic

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/Arch/X86_64.cpp:28
 
-  uint64_t getImplicitAddend(const uint8_t *loc, uint8_t type) const override;
+  uint64_t getImplicitAddend(MemoryBufferRef, const section_64 &,
+                             const relocation_info &) const override;
----------------
smeenai wrote:
> Low-priority follow-up: be consistent about including or not including parameter names in all these declarations, both here and in the header.
my approach has been to omit parameter names when the type is sufficiently descriptive -- which is why the names are present mostly only for parameters with primitive types


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80049/new/

https://reviews.llvm.org/D80049