[PATCH] D79745: [YAMLTraits] Add trait for char

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 21 09:09:10 PDT 2020


JDevlieghere added a comment.

Hey Rainer,

I'm sorry I didn't see your comment earlier. Because of your e-mail address your replies skipped my inbox and ended up in a GCC folder... I'll need to fix that!

If the Solaris build bot is public then reverting is indeed fair game. To the correctness of this patch, if it's allowed for `char` and `uint8_t` to be the same type then this patch is wrong but I'd have to double check this stuff. Regardless, it seems like there's at least one platform where that's the case. Let me see if I can simply work around it and get lldb to build by casting to `uint8_t`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79745/new/

https://reviews.llvm.org/D79745





More information about the llvm-commits mailing list