[PATCH] D80099: [llvm-objcopy][MachO] Add support for removing Swift symbols

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Thanks @alexshap. The only thing outstanding from my point of view, aside from a nit, is documenting the switch. I think we can keep it concise in llvm-strip's documentation by just saying the same thing as the help text. That way, if details change, it's not a problem. Users probably don't need to know the details. BTW, I couldn't quickly find a cctools strip man page online, so I can't comment on their documentation.



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/remove-swift-symbols.test:1
+## Verify that -T removes swift symbols.
+# RUN: yaml2obj -D FLAGS=0x00200085 -D SEGMENT_NAME=__DATA \
----------------
Here and below: swift -> Swift


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80099/new/

https://reviews.llvm.org/D80099