[PATCH] D80311: [lld][test] Expand testing for dynamic-list and export-dynamic

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Generally LG. Few comments below.



================
Comment at: lld/test/ELF/export-dynamic-symbol.s:8
 
-# RUN: ld.lld -shared -o %t.so --export-dynamic-symbol foo %t.a %t2.o
-# RUN: llvm-readelf -dyn-symbols %t.so | FileCheck %s
+# Use --fatal-warnings to confirm no diagnostics are emitted for unexportable symbols.
+# RUN: ld.lld -shared --fatal-warnings  -o %t.so --export-dynamic-symbol foo --export-dynamic-symbol nomatch %t.a %t2.o
----------------
```
##
```


================
Comment at: lld/test/ELF/export-dynamic-symbol.s:9
+# Use --fatal-warnings to confirm no diagnostics are emitted for unexportable symbols.
+# RUN: ld.lld -shared --fatal-warnings  -o %t.so --export-dynamic-symbol foo --export-dynamic-symbol nomatch %t.a %t2.o
+# RUN: llvm-readelf -dyn-symbols %t.so | FileCheck %s --implicit-check-not=nomatch
----------------
A double space after `--fatal-warnings` (and below).


================
Comment at: lld/test/ELF/export-symbol-types.s:1
+## Not exported:
+## - local symbols
----------------
It probably missing a description of what this test case generally checks.


================
Comment at: lld/test/ELF/export-symbol-types.s:17
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/export-symbol-types.s -o %t-shared.o
+# RUN: ld.lld --shared %t-shared.o -o %t.so
----------------
`export-symbol-types.s` is short. Could you use `echo` instead?


================
Comment at: lld/test/ELF/export-symbol-types.s:21
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t-elf.o
+# Use --fatal-warnings to confirm no diagnostics are emitted
+# RUN: ld.lld --fatal-warnings --defsym=defsym=_start %t.so %t-elf.o -o %t.elf --export-dynamic
----------------
```
##
```
Also, full stop is missing.


================
Comment at: lld/test/ELF/export-symbol-types.s:23
+# RUN: ld.lld --fatal-warnings --defsym=defsym=_start %t.so %t-elf.o -o %t.elf --export-dynamic
+
+# RUN: ld.lld --fatal-warnings --defsym=defsym=_start %t.so %t-elf.o -o %tlist.elf --dynamic-list %t.list
----------------
This empty line looks excessive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80311/new/

https://reviews.llvm.org/D80311