[PATCH] D80280: [MLIR] Add `index_to_size` and `size_to_index` to the shape dialect

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.

Looks good modulo small changes.



================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:178
+    between the standard and the shape dialect.
+    Expects an `index` and returns a `shape.size` value.
+  }];
----------------
This is already captured in the arguments and results below (and in generated doc for the ops).


================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:294
+    This operation and its inverse, `index_to_size`, facilitate index conversion
+    between the standard and the shape dialect.
+    Expects a `shape.size` and returns an `index` value.
----------------
size represents a non-negative integer with support for being unknown and invalid, what is the conversion/behavior when the operand is invalid?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80280/new/

https://reviews.llvm.org/D80280