[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

[Reid "Away June-Sep" Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: cfe/trunk/lib/Frontend/CompilerInvocation.cpp:3457
+  if (Diags.isIgnored(diag::warn_profile_data_misexpect, SourceLocation()))
+    Res.FrontendOpts.LLVMArgs.push_back("-pgo-warn-misexpect");
+
----------------
Clang generally tries to avoid relying on LLVM option parsing if at all possible. It is not thread-safe, among other things. This causes essentially every compile to call `llvm::cl::ParseCommandLineOptions`, when previously it would only happen if the user passed unstable -mllvm flags.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66324/new/

https://reviews.llvm.org/D66324