[PATCH] D80313: [SVE] Eliminate calls to default-false VectorType::get() from CodeGen

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 14:53:41 PDT 2020


ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/lib/CodeGen/ValueTypes.cpp:165
 Type *EVT::getTypeForEVT(LLVMContext &Context) const {
+  // clang-format off
   switch (V.SimpleTy) {
----------------
efriedma wrote:
> I think I'd prefer to just let clang-format use its default formatting for this switch... as it is, the code doesn't fit into 80 columns.
Somebody clearly went to great lengths to format this switch nicely, I feel like this is the sort of thing clang-format on/off is for. I don't feel particularly strongly about it either way though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80313/new/

https://reviews.llvm.org/D80313





More information about the llvm-commits mailing list