[PATCH] D80316: [HardwareLoops] Intrinsic descriptions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 13:44:10 PDT 2020


efriedma added a comment.

Changes outside LangRef LGTM; please commit separately.



================
Comment at: llvm/docs/LangRef.rst:14855
+(vector) loop will execute. They are placed in the loop preheader, and are marked
+as ``IntrNoDuplicate`` to avoid optimizers duplicating these instructions.
+
----------------
I think each of these intrinsics needs a "semantics" section that specifies the bare semantics of each intrinsic, without mentioning anything about loops/control flow, assuming that's possible.


================
Comment at: llvm/docs/LangRef.rst:14874
+      declare void @llvm.test.set.loop.iterations.i32(i32)
+      declare void @llvm.tetst.set.loop.iterations.i64(i64)
+
----------------
Signature here is wrong?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80316/new/

https://reviews.llvm.org/D80316





More information about the llvm-commits mailing list