[PATCH] D79283: [PowerPC] Add missing handling for half precision

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 08:43:10 PDT 2020


nemanjai marked an inline comment as done.
nemanjai added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/scalar_vector_test_2.ll:11
 
 define void @test_liwzx1(<1 x float>* %A, <1 x float>* %B, <1 x float>* %C) {
 ; P9LE-LABEL: test_liwzx1:
----------------
amyk wrote:
> This test case seems to originally test for instructions like `lfiwzx` like the name of the function suggests, but that doesn't seem to be the case anymore. 
> 
> I am just wondering if this is a concern and should test purpose should change (in terms of maybe the function/file name, or something)?
I think we can probably remove this test case since a one element vector should be scalarized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79283/new/

https://reviews.llvm.org/D79283





More information about the llvm-commits mailing list